[Sugar-devel] [PATCH] Time out on registration process to prevent indefinite UI hang (SL#2289)

Sascha Silbe sascha-ml-reply-to-2010-3 at silbe.org
Tue Sep 7 14:19:53 EDT 2010


Excerpts from Dipankar Patro's message of Tue Sep 07 19:44:17 +0200 2010:

> +class TimeoutHTTP(httplib.HTTP):
> +   def __init__(self, host='', port=None, strict=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT):

Line too long (> 80 chars). I don't think you'll ever get passed timeout
as a parameter, so just use a local variable instead.

Otherwise your patch looks fine.

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100907/d0fa8ff4/attachment.pgp 


More information about the Sugar-devel mailing list