[Sugar-devel] Patch review request for ticket #2290

Marco Pesenti Gritti marco at marcopg.org
Mon Sep 6 19:28:01 EDT 2010


On Mon, Sep 6, 2010 at 6:04 PM, Dipankar Patro <dipankar at seeta.in> wrote:
> Sorry for that duplicate bug. Missed out that lfaraone already filed the
> bug.
>
> I have attached the revised patch. (uploaded at bugs.sl.o too)
> * changed things (subject, description, etc) according to Sascha Silbe's
> suggestions.
>
> @ Marco : The default timeout is way too long (unable to find out exact
> time). Yes, the process is synchronous, thats why Sugar is freezing.

With Tomeu clarification the very short timeout make sense. As Sascha
suggested the log should explain why we are doing this though. I think
it would be good to also put a similar comment in a FIXME in the code.

Marco


More information about the Sugar-devel mailing list