[Sugar-devel] [PATCH] Set max_column value according to screen width. Ticket #2280

[Gary Martin]

Hi Neeraj,

Sorry to spot this so late.

On 5 Sep 2010, at 15:08, Neeraj Gupta wrote:

> This patch set the value of maximum number of column in control panel display
> according to the screen resolution.

I'm pretty sure there is a patch already, fairly reviewed and tested in the dextrose release for Paraguay that has not yet been merged in Sugar mainline :-( It was listed in Bernie's email of F11-0.88 unmerged patches called "sugar/dynamically-set-number-of-control-panel-columns.patch" I think Anish Mangal landed a slightly improved version in their rep. Sorry, have been searching the bugs.sugarlabs.org but can not find an official ticket. Anish/Bernie can you point to the patch/commit so we can get an official trac filed for mainline review (or whatever the plat du jour is for the review process)?

Regards,
--Gary

> ---
> src/jarabe/controlpanel/gui.py |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/jarabe/controlpanel/gui.py b/src/jarabe/controlpanel/gui.py
> index 51d9820..e9368d2 100644
> --- a/src/jarabe/controlpanel/gui.py
> +++ b/src/jarabe/controlpanel/gui.py
> @@ -33,7 +33,7 @@ from jarabe.controlpanel.toolbar import SectionToolbar
> from jarabe import config
> 
> _logger = logging.getLogger('ControlPanel')
> -_MAX_COLUMNS = 5
> +_MAX_COLUMNS = gtk.gdk.screen_width()/(3*style.GRID_CELL_SIZE)
> 
> class ControlPanel(gtk.Window):
>     __gtype_name__ = 'SugarControlPanel'
> -- 
> 1.7.0.4
> 
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel