[Sugar-devel] [PATCH] Protected-Activities-Support.3
sascha-ml-reply-to-2010-3 at silbe.org
Sat Sep 4 16:18:22 EDT 2010
Excerpts from Kandarp Kaushik's message of Sat Sep 04 21:41:10 +0200 2010:
Thanks for submitting the patch with git send-email, I could apply it
- test your patch before submitting it (there's a syntax error)
- provide a useful subject and description
- fix the white space errors (I recommend using
"git config --global color.diff auto" to enable diff coloring)
- adjust the _add_erase_option() docstring: only "user" activities
(i.e. those in ~/Activities) can be removed at all, so
"user or unprotected activities" doesn't make sense.
On the ticket  Gary suggested to deactivate (instead of remove) the
Erase option for protected activities (like we're already doing for
"system" activities). +1 from me, but maybe someone else from the design
team wants to chime in.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100904/a6cfeb5f/attachment.pgp
More information about the Sugar-devel