[Sugar-devel] [Dextrose] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080

[Martin Dengler]

On Fri, Oct 29, 2010 at 05:18:05PM +0100, Gary Martin wrote:
> On 29 Oct 2010, at 09:12, Martin Dengler <martin at martindengler.com> wrote:
> 
> > On Thu, Oct 28, 2010 at 03:44:37PM -0300, Gonzalo Odiard wrote:
> >> I think the problem is the code is rendering the svg icon every time
> >> the color is changed.
> > 
> > Indeed.  As James Cameron pointed out, we're setting the stroke and
> > fill in rapid succession, resulting in two calls to render().
[...]
> > I'd love any feedback.
> 
> I've been testing this patch on an XO-1 F14 0.90 build today and can
> confirm the svg icon appears in the launcher about one second after
> starting/resuming an activity from the home view. Fab! :)

Cool.

> It's worth a note that the zoom in effect is still lost for most svg icons, only for the very simple icons is the effect visible (Log icon is simple enough to show it, Distance icon is not quick enough). The zoom animation is defaulting to 20 fps which can't be helping, but lowering it to 10fps doesn't seem to help enough to make much of a visible improvement. I only reliably started to see the zoom when I also increased the length of the zoom effect from 1sec to 2sec by modifying launcher.py #116:
> 
>         self._animator = animator.Animator(2.0, fps=10)
> 
> ...so I guess that first second of launching is still rather swamped
> so the first second of zoom is usually skipped. Hmmm, maybe the zoom
> start should be triggered only once the first update has hit.

Interesting.  I'll have a look at that.  I'm also interested in why
the zoom effect moves the icon around on the screen so much - using my
profile-pulsingicon.py test on my low-to-mid end laptop, I can clearly
see the icon, when "zooming", wobbling around the center
significantly.

> Regards,
> --Gary

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101031/a3a35a94/attachment-0001.pgp>