[Sugar-devel] [Dextrose] request for review of pending patches

[Bernie Innocenti]

On Sat, 2010-10-30 at 04:07 +0530, Manusheel Gupta wrote:
> We have summed up our recent work on feature requests and bug fixing
> at http://wiki.sugarlabs.org/go/Dextrose/BugBashing.

This summary is *neat*!


> It would be great if patches on SL #305 (Checkbox outline changed when
> activated)

This seems to be waiting for Benjamin Berg's approval. Thus cc'ing him.


>  and #2201 (Clipboard menu offscreen) could be reviewed.

For #2201, I have two small observations (not a full review):

>-        Palette.__init__(self, text_maxlen=100)
>+        char_lable = gtk.Label()
>+        create_layout = char_lable.create_pango_layout("W")

Since Gtk already prefers the American spelling, our code would look more consistent if we did the same.

>+        Palette.__init__(self, text_maxlen=int(0.75 * gtk.gdk.screen_width
>+        () / create_layout.get_pixel_size()[0]))

Indentation seems odd. Perhaps the developer uses an editor with
automatic text wrapping enabled?

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/