[Sugar-devel] [Dextrose] [PATCH] New suggestion for arrow drawing in Paint activity.olpc4170

James Cameron quozl at laptop.org
Wed Oct 20 21:57:58 EDT 2010

On Wed, Oct 20, 2010 at 10:16:52PM -0200, Bernie Innocenti wrote:
> On Wed, 2010-10-20 at 21:36 +0530, Anurag Chowdhury wrote:
> > I have uploaded the icon file at https://dev.laptop.org/ticket/4170
> > needed for the patch.
> It would be better if you could keep the icons with the patches.

I disagree, sometimes they significantly hinder code review.  It is up
to the author of the patch to figure out how to present it best for
review.  Sometimes this might be as a separate patch.

Maybe I'm missing something.  I use mutt.  Given a git format-patch in
e-mail with an added SVG, what tool chain do you engage to review the

James Cameron

More information about the Sugar-devel mailing list