[Sugar-devel] [PATCH sugar-base 00/17] style cleanup series

Sascha Silbe sascha-pgp at silbe.org
Sat Oct 16 07:30:13 EDT 2010

This is the sugar-base part of the style cleanups I've wanted to
land at least two releases ago, but kept missing the window.

I have done some basic testing, but naturally cannot test all code
paths I've touched (some even appear to be unused). This is why I'd like
to land this right after we branched off sucrose-0.90: to ensure it gets
enough testing before the next release.

After this series sugar-base is pep8 and pylint clean.

Sascha Silbe (17):
  fix EOL spaces
  maint-helper.py: remove outdated URL
  PEP8 cleanup: fix number of blank lines
  sugar.dispatch.saferef: don't use assert for critical code paths
  PEP8 cleanup: fix spaces around operators and parentheses
  sugar.dispatch.dispatcher: remove fallback for Python 2.3
  PEP8 cleanup: ensure lines are shorter than 80 characters
  PEP8 cleanup: don't use has_key()
  PEP8 cleanup: import only one module per import statement
  style cleanup: prefer ' for strings
  pylint cleanup: replace disable-msg with disable
  pylint: sugar.logger: allow overriding module name
  maint-helper: rename parameter to avoid name clash with built-in
  sugar.dispatch.saferef: ignore incorrect pylint warning
  pylint cleanup: sugar.dispatch.saferef: remove unused variable
  pylint cleanup: Signal._live_receivers: mark receiverkey as unused
  sugar.mime: ignore incorrect pylint warning

 maint-helper.py                  |   40 +++++++++------
 src/sugar/dispatch/__init__.py   |    3 +-
 src/sugar/dispatch/dispatcher.py |   42 ++++++++--------
 src/sugar/dispatch/saferef.py    |  102 ++++++++++++++++++++------------------
 src/sugar/logger.py              |   14 +++---
 src/sugar/mime.py                |    1 +
 6 files changed, 107 insertions(+), 95 deletions(-)

More information about the Sugar-devel mailing list