[Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)
dipankar at seeta.in
Thu Oct 14 03:41:24 EDT 2010
Glad I could clarify my modifications. :)
I will send the corrected e-mail as soon as possible.
On Thu, Oct 14, 2010 at 4:29 AM, James Cameron <quozl at laptop.org> wrote:
> On Wed, Oct 13, 2010 at 04:31:00PM +0530, Dipankar Patro wrote:
> > Thanks for reviewing it, James.
> Sorry, it was late, and I misunderstood the code you had written ... I
> withdraw my comment "You are effectively repeating the previous if
> statement but using the output ... seems a bit obscure."
Apart from the lack of text wrap in the commit message, I've no issues
> with the patch.
> Reviewed-by: James Cameron <quozl at laptop.org>
> James Cameron
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Sugar-devel