[Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

James Cameron quozl at laptop.org
Wed Oct 13 18:59:51 EDT 2010


On Wed, Oct 13, 2010 at 04:31:00PM +0530, Dipankar Patro wrote:
> Thanks for reviewing it, James.

Sorry, it was late, and I misunderstood the code you had written ... I
withdraw my comment "You are effectively repeating the previous if
statement but using the output ... seems a bit obscure."

Apart from the lack of text wrap in the commit message, I've no issues
with the patch.

Reviewed-by: James Cameron <quozl at laptop.org>

-- 
James Cameron
http://quozl.linux.org.au/


More information about the Sugar-devel mailing list