[Sugar-devel] [PATCH v2 Sugar] Pulsing icon delayed by 5 seconds or so SL#2080

[Sascha Silbe]

Excerpts from Anurag Chowdhury's message of Thu Oct 07 20:26:41 +0200 2010:

> +COUNTER = 1
>  
>  class Animator(gobject.GObject):

Please see PEP-8 [1], "Code lay-out", "Blank Lines", first paragraph.

> +            for COUNTER in range(0, 5):
> +               easing = EASE_IN_EXPO
> +               duration = duration*100
> +               COUNTER = COUNTER + 1

Please read the Python tutorial regarding for-loops [2] and the range
function [3]. Also local variables should be lowercase.

Sascha

[1] http://www.python.org/dev/peps/pep-0008/
[2] http://docs.python.org/tutorial/controlflow.html#for-statements
[3] http://docs.python.org/tutorial/controlflow.html#the-range-function
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/private/sugar-devel/attachments/20101007/718fd85a/attachment.pgp>