[Sugar-devel] [PATCH] Avoid popping an empty list in the

Sascha Silbe sascha-ml-reply-to-2010-3 at silbe.org
Tue Nov 30 15:35:33 EST 2010


Excerpts from Michael Stone's message of Wed May 26 06:27:07 +0200 2010:
> > On Sun, May 23, 2010 at 02:50:16PM -0400, Michael Stone wrote:
> > > When you run Sugar with no activities installed,
> > > UpdateModel._bundles_to_check is empty. Attempting to unconditionally
> > > pop this list results in an IndexError.  Instead, the updater should
> > > stop trying to update bundles when it determines that it has no more
> > > bundles to check.
[some changes suggested by James]
> Good suggestion.

AFAICT this hasn't been fixed yet. I would appreciate an updated
(single) patch that we can review and merge into master.

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101130/2ca901dc/attachment.pgp>


More information about the Sugar-devel mailing list