[Sugar-devel] [PATCH] FEATURE REQUEST : Write_to_journal_anytime

[Sascha Silbe]

Excerpts from anubhav's message of Tue Nov 30 06:49:42 +0100 2010:

You break threading by supplying an invalid message id in the following
headers:

> In-Reply-To: <no>
> References: <no>

This makes it rather hard for me to review your patch. If you'd like me
to review your patch, please submit it again without passing
"--in-reply-to=no" to git send-email.

You can also adjust the subject. The patch isn't a feature request, it's
an implementation of a feature. A better summary of what your patch does
would be:

Add button in activity toolbar to invoke the Name Alert


I'm also not exactly fond of the Name Alert. I'd much rather have that
button invoke the Journal details view instead. But that's my personal
opinion, so I recommend you wait until the Design Team has agreed on a
choice.

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101130/9b773398/attachment.pgp>