[Sugar-devel] [PATCH sugar-toolkit] XoColor: don't choke if passed the wrong type (SL#1408)

[Simon Schampijer]

On 10/17/2010 12:09 PM, Sascha Silbe wrote:
> Color data is stored in the Journal as a JSON dump, so we can get back
> arbitrary types. XoColor already checks the color string for validity and
> handles invalid strings gracefully, so it makes sense to enhance this to
> invalid types as well.
>
> Signed-off-by: Sascha Silbe<sascha-pgp at silbe.org>

Acked-by: Simon Schampijer <simon at schampijer.de>

This one looks good. I would probably note the ticket number in the 
sub-comment as the ticket itself does not make the context directly 
visible. Or name it (part of SL#1408).

Thanks,
    Simon