[Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

Simon Schampijer simon at schampijer.de
Mon Nov 29 04:19:40 EST 2010


On 11/28/2010 11:11 AM, Gary Martin wrote:
> On 27 Nov 2010, at 20:41, Sascha Silbe<sascha-ml-reply-to-2010-3 at silbe.org>  wrote:
>
>> Excerpts from shanjit's message of Sat Nov 13 13:08:14 +0100 2010:
>>
>>> diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py
>>> index 3a54464..4242105 100644
>>> --- a/extensions/deviceicon/speaker.py
>>> +++ b/extensions/deviceicon/speaker.py
>>> @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):
>>>
>>>          self.connect('expose-event', self.__expose_event_cb)
>>>
>>> -        self._icon_widget.connect('button-release-event',
>>> -                                  self.__button_release_event_cb)
>>> -
>>
>> If there is no primary action (anymore), we should open the palette on
>> left-click.
>
> Good design catch, +1! I need to remember to go file tickets for other cases in Sugar, the really obvious one being the owners central XO icon on the neighbourhood, groups, and favourite views.
>
> --Gary

Good catch. And yes, Gary would be great if we could reach a consistent 
state here.

Regards,
    Simon


More information about the Sugar-devel mailing list