[Sugar-devel] [PATCH] OLPC #8857 - Browse fails to download some files with non-ascii characters
Sascha Silbe
sascha-ml-reply-to-2010-3 at silbe.org
Tue Nov 23 10:15:03 EST 2010
Excerpts from Simon Schampijer's message of Tue Nov 23 14:45:36 +0100 2010:
> Ok, I just had a look at your code. The charset we are passing to
> nsITextToSubURI [1], looks correct for the cases I tested (e.g. [2]),
> and does provide fallback mechanisms in the sense that it does not break
> when a wrong charset is used to encode. For example I passed 'UTF-8'
> when escaping the example and the url just did not look escaped right,
> but the download did finish fine etc.
Thanks for testing!
I'll merge this soon (after adjusting the description to include the
results of your test), unless Lucian comes up with a reason not to.
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101123/4581d2b8/attachment-0001.pgp>
More information about the Sugar-devel
mailing list