[Sugar-devel] [Dextrose] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

[Bernie Innocenti]

Steven, can we apply this patch to dextrose? It's a big usability fix.

Reviewed-by: Bernie Innocenti <bernie at codewiz.org>


On Sat, 2010-11-13 at 08:15 -0500, Gonzalo Odiard wrote:
> Reviewed-By: gonzalo at laptop.org
> 
> On Sat, Nov 13, 2010 at 7:08 AM, <shanjit at seeta.in> wrote:
>         From: Shanjit Singh Jajmann <shanjit at seeta.in>
>         
>         Muting by clicking on the icon is killed.
>         ---
>          extensions/deviceicon/speaker.py |   10 ----------
>          1 files changed, 0 insertions(+), 10 deletions(-)
>         
>         diff --git a/extensions/deviceicon/speaker.py
>         b/extensions/deviceicon/speaker.py
>         index 3a54464..4242105 100644
>         --- a/extensions/deviceicon/speaker.py
>         +++ b/extensions/deviceicon/speaker.py
>         @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):
>         
>                 self.connect('expose-event', self.__expose_event_cb)
>         
>         -        self._icon_widget.connect('button-release-event',
>         -
>          self.__button_release_event_cb)
>         -
>                 self._update_info()
>         
>             def create_palette(self):
>         @@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
>                 self.icon.props.icon_name = get_icon_state(name,
>         current_level, step=-1)
>                 self.icon.props.xo_color = xo_color
>         
>         -    def __button_release_event_cb(self, widget, event):
>         -        if event.button == 1:
>         -            self._model.props.muted = not
>         self._model.props.muted
>         -            return True
>         -        else:
>         -            return False
>         -
>             def __expose_event_cb(self, *args):
>                 self._update_info()
>         
>         --
>         1.7.2.2
>         
>         _______________________________________________
>         Sugar-devel mailing list
>         Sugar-devel at lists.sugarlabs.org
>         http://lists.sugarlabs.org/listinfo/sugar-devel
> 
> _______________________________________________
> Dextrose mailing list
> Dextrose at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/dextrose









-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/