[Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

[Gonzalo Odiard]

On Wed, Nov 3, 2010 at 12:24 AM, Anish Mangal <anish at sugarlabs.org> wrote:

> Hi,
>
> Thank you for the patch, however,
>
> * I'd prefer two patches for two different changes (layout
> compatibility fix, edit toolbar), as I mailed earlier.
>

Ok, resolve first the last. Does not have sense make two patches if you
don't want to use these changes.


> * Your patch moves the activity-exit button to the left for sugar
> 0.88+. This [1] is how it should look.
>

Done


> * Regarding the layout-fix, your patch introduces a 'new toolbar' to
> contain the run/stop/clear buttons. There have been discussions on
> list[2] and on IRC w/ erikos, garycmartin (IIRC), and we had decided
> on keeping the old pippy layout for sugar <=0.84. I'd like to keep it
> that way unless you can throw a good argument into the mix.
>
>
I think we can discuss if is better have two toolbars (one for
run/stop/clear and another to edit buttons) or have only one toolbar.
In Sugar usually we use a separated toolbar to the edit buttons, but a
development environment like Pippy can be a exception.

About using a toolbar or the old gtk buttons, my arguments are:
* The activity looks more integrated to Sugar
* Better screen usage
* The code is cleaner.

May be Gary and Simon can take a look again?

Gonzalo

Attached is the patch wth the quit button at the right.


[1] http://people.sugarlabs.org/anish/pippy.png
> [2] http://lists.sugarlabs.org/archive/sugar-devel/2010-July/0My
> arguments  are:25756.html<http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025756.html>
>
> On Wed, Nov 3, 2010 at 8:10 AM, Gonzalo Odiard <godiard at sugarlabs.org>
> wrote:
> > This patch modify the last two patches from Anish to enable the use of
> the
> > right toolbars in every Sugar version.
> > There are screenshots here:
> > http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.84.png<http://dev.laptop.org/%7Egonzalo/pippy-in-sugar-0.84.png>
> > http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.90.png<http://dev.laptop.org/%7Egonzalo/pippy-in-sugar-0.90.png>
> >
> > Gonzalo
> >
> > _______________________________________________
> > Sugar-devel mailing list
> > Sugar-devel at lists.sugarlabs.org
> > http://lists.sugarlabs.org/listinfo/sugar-devel
> >
> >
>
>
>
> --
> Anish
>



-- 
Gonzalo Odiard
SugarLabs Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101103/ec44e437/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-EditToolbar-and-modify-toolbars-to-support-the-o.patch
Type: text/x-diff
Size: 8463 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20101103/ec44e437/attachment.patch>