[Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

[Anish Mangal]

Hi,

Thank you for the patch, however,

* I'd prefer two patches for two different changes (layout
compatibility fix, edit toolbar), as I mailed earlier.
* Your patch moves the activity-exit button to the left for sugar
0.88+. This [1] is how it should look.
* Regarding the layout-fix, your patch introduces a 'new toolbar' to
contain the run/stop/clear buttons. There have been discussions on
list[2] and on IRC w/ erikos, garycmartin (IIRC), and we had decided
on keeping the old pippy layout for sugar <=0.84. I'd like to keep it
that way unless you can throw a good argument into the mix.

[1] http://people.sugarlabs.org/anish/pippy.png
[2] http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025756.html

On Wed, Nov 3, 2010 at 8:10 AM, Gonzalo Odiard <godiard at sugarlabs.org> wrote:
> This patch modify the last two patches from Anish to enable the use of the
> right toolbars in every Sugar version.
> There are screenshots here:
> http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.84.png
> http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.90.png
>
> Gonzalo
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>



-- 
Anish