[Sugar-devel] More Sugar 0.88 bugs to work on

[Bernie Innocenti]

El Fri, 28-05-2010 a las 15:18 +1000, James Cameron escribió:
> On Thu, May 27, 2010 at 09:17:11AM -0400, Bernie Innocenti wrote:

> > >=== Bugs reported against os240 ===
> > >[ ] Alt-1 does not capture a screenshot
> 
> It does for me!  (os240py).

Uh?!? How did you do that?  Doesn't work for me, no matter how hard I
try...


> > Probably the same of ALT-Tab not working. I bet we're eating all the
> > ALT events for the start-new function in the Favorites view. Who would
> > like to work on this?
> 
> Alt/Tab doesn't work for me on os240py.
> 
> Here's some test results:
> 
> 1.  temporarily removed HomeWindow.__init__() connect calls for
> key-press-event and key-release-event, restarted, no change to symptom,
> but the start-new function is certainly disabled,
> 
> 2.  in Terminal, using Alt/Tab is being handled by the shell in the
> Terminal, and displays words from shell history, suggesting that a
> modifier is visible to the shell, therefore it is being passed to the
> terminal emulation ... which means in turn that there is no X client
> that has a grab on the key, which is what a window manager would
> normally do.
> 
> 3.  xev over ssh shows Alt key is "keycode 64 (keysym 0xffe9, Alt_L)",
> and Alt/Tab is "state 0x8, keycode 23 (keysym 0xff09, Tab)" which
> verifies that no X client has the key grabbed.
> 
> My gut feel is that the globalkey key grabber called in KeyHandler isn't
> aware of an Alt/Tab binding.

Thank you very much for looking into it!

Next step could be running a git log -p on keyhandler.py to see what
change might have broken alt-tab.

This commit looks very suspicious, although I cannot do any testing now:

commit b0520607503b0876020d5e764b1a98322a2bf949
Author: Aleksey Lim <alsroot at member.fsf.org>
Date:   Fri Oct 9 17:31:02 2009 +0000

    Alt+Space not working to show/hide the tray #1476

diff --git a/src/jarabe/view/keyhandler.py
b/src/jarabe/view/keyhandler.py
index 478a4c0..acbbb04 100644
--- a/src/jarabe/view/keyhandler.py
+++ b/src/jarabe/view/keyhandler.py
@@ -74,8 +74,6 @@ class KeyHandler(object):
         self._keystate_pressed = 0
         self._speech_proxy = None
 
-        self._ungrab_metacity_keys()
-
         self._key_grabber = KeyGrabber()
         self._key_grabber.connect('key-pressed',
                                   self._key_pressed_cb)
@@ -101,15 +99,6 @@ class KeyHandler(object):
 
         self._key_grabber.grab_keys(_actions_table.keys())
 
-    def _ungrab_metacity_keys(self):
-        """So we can grab those instead.
-        """
-        client = gconf.client_get_default()
-        for key in ['run_command_screenshot', 'switch_windows',
-                    'cycle_windows']:
-            key = '/apps/metacity/global_keybindings/' + key
-            client.set_string(key, 'disabled')
-
     def _change_volume(self, step=None, value=None):
         if step is not None:
             volume = sound.get_volume() + step


-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/