[Sugar-devel] [PATCH v1 00/10] Journal sorting by file size and creation time.

[Gary C Martin]

Hi Andrés,

On 27 May 2010, at 03:08, Andrés Ambrois wrote:

> On Wednesday 26 May 2010 02:39:01 pm Gary C Martin wrote:
>> Hi Andrés,
>> 
>> On 24 May 2010, at 01:16, Andrés Ambrois wrote:
>> 
>>> On Sunday 23 May 2010 04:08:51 pm Michael Stone wrote:
>>>> Andrés,
>>>> 
>>>> I've read these patches and tested them locally (with minor changes due 
> to
>>>> merge conflicts with some of my experimental work) and the results are 
> quite
>>>> pleasing to me.
>>> 
>>> Thanks!
>>> 
>>>> The one issue that I would like you to fix before I merge these patches 
> into 
>>> my
>>>> tree is that I would like you to include additional patches for the new 
>>> icons
>>>> that your ListViewButton requires to function as intended. 
>>>> 
>>>> (I don't really care whether the new icons are different from the old 
> icons; 
>>> I
>>>> merely care that I still have a normal-looking ListViewButton after I 
> select
>>>> one of your new sort modes rather than the thin grey bar that I currently 
>>> see.)
>>> 
>>> I only have the filesize icon I made for testing, but I usually stay away 
> from 
>>> graphics work (I suck at GIMP). 
>>> 
>>> Gary, I see you uploaded [0] to the wiki, which is what this patchset is 
> based 
>>> on. Do you have SVG versions of the icons you put in there?
>> 
>> I've built the 3 icons out as SVGs attached, here's PNGs of them as well for 
> easier quick review:
> 
> Thanks a lot Gary! Attached are a couple of screenshots.

Hey, that's looking great.

> I've been thinking if the ListViewButton icon should change.

Yes changing the icon seems helpful, though we'd need to make sure all the 'sort by' icons all are clearly icons representing sorting when seen individually. I'll have a think. Perhaps some simple visual element that's part of all icons so that they are all clearly types of sort. The current icons could become badges to this other visual; or the other visual could be used to badge the current icons.

> The last column 
> should be sufficient indication of when we are sorting by file size, but there 
> seems to be no other way of distinguishing between creation time and last edit 
> time... thoughts?

Perhaps controversial... sorting by creation time could show absolute date strings, rather than relative. When sorting by creation date it could be argued the actual date is more useful (eg, what were the photos I took on my grandmothers birthday, my school opening day, a national holiday).

Regards,
--Gary