[Sugar-devel] [PATCH v1 00/10] Journal sorting by file size and creation time.

[Gary C Martin]

Hi Andrés,

On 24 May 2010, at 01:16, Andrés Ambrois wrote:

> On Sunday 23 May 2010 04:08:51 pm Michael Stone wrote:
>> Andrés,
>> 
>> I've read these patches and tested them locally (with minor changes due to
>> merge conflicts with some of my experimental work) and the results are quite
>> pleasing to me.
> 
> Thanks!
> 
>> The one issue that I would like you to fix before I merge these patches into 
> my
>> tree is that I would like you to include additional patches for the new 
> icons
>> that your ListViewButton requires to function as intended. 
>> 
>> (I don't really care whether the new icons are different from the old icons; 
> I
>> merely care that I still have a normal-looking ListViewButton after I select
>> one of your new sort modes rather than the thin grey bar that I currently 
> see.)
> 
> I only have the filesize icon I made for testing, but I usually stay away from 
> graphics work (I suck at GIMP). 
> 
> Gary, I see you uploaded [0] to the wiki, which is what this patchset is based 
> on. Do you have SVG versions of the icons you put in there?

I've built the 3 icons out as SVGs attached, here's PNGs of them as well for easier quick review:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-lastedit.png
Type: image/png
Size: 6832 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0003.png 
-------------- next part --------------
  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-created.png
Type: image/png
Size: 7029 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0004.png 
-------------- next part --------------
  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-size.png
Type: image/png
Size: 6407 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0005.png 
-------------- next part --------------


Would love to see a quick screenshot of them in place in the palette ? it is usually a bit of a struggle (time wise) for me to apply patches and see for myself.

Regards,
--Gary

>> Regards, and thanks for all your hard work here,
> 
> Thank you for reviewing!
> 
>> Michael
>> 
> [0] 
> http://wiki.sugarlabs.org/go/File:Journal_mockup_gary_list_extended_palette.png
> -- 
>  -Andrés

-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-created.svg
Type: image/svg+xml
Size: 1146 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0003.svg 
-------------- next part --------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-lastedit.svg
Type: image/svg+xml
Size: 1346 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0004.svg 
-------------- next part --------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: view-size.svg
Type: image/svg+xml
Size: 744 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100526/a99ca096/attachment-0005.svg