[Sugar-devel] [PATCH] touchpad section for Sugar Control Panel

[Paul Fox]

sascha wrote:
 > Excerpts from Walter Bender's message of Tue May 18 20:08:58 +0000 2010:
 > > I've attached two patches: (1) a new touchpad section for the control
 > > panel and (2) new icons for sugar-artwork used by the control panel.
 > Thanks for working on this!
 > While at least some users will probably want a faster way (read: a hotkey)
 > to do this, a Control Panel section is more discoverable and a hotkey
 > would be better implemented in olpc-kbdshim rather than Sugar.
 > 
 > > We still need a script t be added to olpc-utils that is executed at
 > > boot time to: (1) change the mode of
 > > /sys/devices/platform/i8042/serio1/ptmode to 666; and (2) write a 1 to
 > > that node if a flag file exists ("/home/olpc/.olpc-pentablet-mode").
 > I'd prefer that code to live in olpc-kbdshim as olpc-utils is specific to
 > the OLPC builds.

the touchpad mode has nothing to do with kbdshim, and vice-versa.

 > 
 > [extensions/cpsection/touchpad/model.py]
 > > def get_touchpad():
 > >     """Get the touchpad mode."""
 > >     if path.exists('/home/olpc/.olpc-pentablet-mode'):
 > Again, this won't work on non-OLPC builds. For this reason I can't test
 > your patch, sorry.

would moving the flag file to a persistent location under /var be
more appropriate?

 > 
 > > def set_touchpad(touchpad):
 > >     """Set the touchpad mode."""
 > >     if touchpad == _CAPACITIVE:
 > >         system("rm /home/olpc/.olpc-pentablet-mode")
 > Please use os.remove() instead.
 > 

i noticed that too.  also, the last version i read still invoked
the touch command -- the "touch" could change to opening the file
for writing, then closing. 

paul
=---------------------
 paul fox, pgf at laptop.org