[Sugar-devel] [PATCH] Remove unused MANIFEST support

[James Cameron]

On Thu, May 20, 2010 at 03:09:58AM -0400, Bernie Innocenti wrote:
> Unless we have imminent plans to make the MANIFEST actually do
> something useful anytime soon, I'd offer the following flamebait^W
> code simplification patch:

Respun for 0.84 and tested on XO-1.5 os125.

Activities continue to start normally.  Invokation of fix_manifest
generates an appropriate message.  When I removed all the
Activities/*/MANIFEST files and restarted, everything continued to work
fine.

I did a side-by-side test with an XO-1.5 with the patch, and one
without.  I configured the kernels to avoid flushing dirty buffers to
SD.  I measured the time taken to restart Sugar to the activity ring, over
several cycles.

There was no observable performance improvement from the patch, and so I
don't recommend it for performance reasons.

(On the other hand, the same change on 0.82 has had a dramatic effect in
the past, because 0.82 generated errors in shell logs for every MANIFEST
inconsistency.  Therefore the change might be considered for backport to
0.82 deployments.)

--