[Sugar-devel] [RFC PATCH v0 0/8] Journal sorting by file size and creation time.

[Bernie Innocenti]

I'm unqualified to review your code, but I've included both your patch
series both in my sugar-jhbuild environment and in my Sugar 0.88
packages for Fedora 11.


El Sat, 01-05-2010 a las 16:33 -0300, Andrés Ambrois escribió:
> Andrés Ambrois (8):
>   Journal: Retrieve ctime and filesize from the datastore.
>   Add ctime and filesize columns to the journal list model.
>   Add add_separator method for convenience.
>   Add a ListViewButton to the journal search toolbar.
>   Rename the date column to 'sort_column'
>   Add sort_by method to the journal list view.
>   Call sort_by in the list view when sorting is selected in the toolbar.
>   Expandedentry: Try to use the filesize property.

Tested-by: Bernie Innocenti <bernie at codewiz.org>


>Andrés Ambrois (2):
>  Add ctime and timestamp properties to the index.
>  Add migration from DS v0 code for the new properties.

Tested-by: Bernie Innocenti <bernie at codewiz.org>


Problems:

 * size display does not work on removable devices: all files are shown
as empty.

 * I forgot to include the patch to increment CURRENT_LAYOUT_VERSION,
which caused old journal entries to report an empty size, but no other
problems.

 * The icon for the new toolbar button is missing

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/