[Sugar-devel] [PATCH] bundlebuilder should not use locale name

[Michael Stone]

On Mon, 26 Apr 2010 17:42:37 -0400, Walter Bender <walter.bender at gmail.com> wrote:
> diff --git a/src/sugar/bundle/activitybundle.py
> b/src/sugar/bundle/activitybundle.py
> index a1f10b9..c83257f 100644
> --- a/src/sugar/bundle/activitybundle.py
> +++ b/src/sugar/bundle/activitybundle.py
> @@ -69,6 +70,9 @@ class ActivityBundle(Bundle):
>          if linfo_file:
>              self._parse_linfo(linfo_file)
>
> +        if self._local_name == None:

This line should test self._local_name against None with "is" rather
than with "==" to better conform to PEP-8.

Otherwise, the patch looks good to me.

I have merged it into my repo:

  http://dev.laptop.org/git/users/mstone/sugar/commit/?id=78a59e6c

with the change mentioned above.
  
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100508/613b098d/attachment.pgp