[Sugar-devel] [PATCH] Pippy: add COPYING file: #1571

[James Cameron]

G'day Sascha,

Thanks for the review.  I've rewritten the patch accordingly.

On Thu, May 06, 2010 at 10:22:25AM +0200, Sascha Silbe wrote:
> == activity.py, library/pippy/__init__.py, library/pippy/game.py,
> library/pippy/sound.py, pippy_app.py ==
> >-# Copyright 2007-8 One Laptop per Child Association, Inc.
> >+# Copyright (C) 2007-8 One Laptop per Child Association, Inc.
> Can we make that 2007-2008, please? It took me a while to understand
> what's meant.

Agreed, changed to "2007,2008", following peer review in #olpc-devel.

> >+# You should have received a copy of the GNU General Public License
> >+# along with this program; if not, write to the Free Software
> >+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> >02110-1301  USA
> At least as of GPLv3, the recommendation changed to use a URL in
> place of the postal address:

True, but not relevant since that license header is GPLv2+, and so I
should stick to the wording recommended by GPLv2+.  I should not use
GPLv3 recommendations on GPLv2 headers.

> We have a problem here: GPLv2 and GPLv3 are incompatible [1].

Yes, they are incompatible.

Either the Elements source was drawn in when it was GPLv2 and I've
improperly used a later GPLv3 license, or when the source was drawn in
the Pippy activity should have been moved to GPLv3.

> We should try to upgrade the GPLv2 parts to GPLv3 to fix this.

Yes, something should be done, but meanwhile this patch improves the
situation by better describing it, and so the incompatibility should not
prevent merging of the patch.  Do you agree?

Here is the revised patch, with your review suggestions and a rewritten
commit message: