[Sugar-devel] [PATCH] New Toolbar for Physics Activity

[Gary Martin]

Hi Akash,

On 24 Jun 2010, at 21:25, Akash Gangil wrote:

> Hi Gary,
> 
>> Make your changes, commit, push, and then request a merge?
> 
> I have filed the merge request.Please look into it. Also I made it backward compatible to previous sugar versions as you suggested. It would fall back to older toolbar design in case of previous sugar versions.

I've just tested under Sugar 0.88, 0.84, and 0.82. I am going to merge your patch tomorrow, but will also make a couple changes of my own before making the next official release:

1) Testing with 0.84 and 0.82 displays multiple create tabs running off the right edge of the screen, the first create tab contains the correct tools, all the others are empty.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: physics testing 0_82 and 0_84.png
Type: image/png
Size: 20076 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100625/ea91be6c/attachment-0002.png 
-------------- next part --------------


2) I like your new create icon (shown below), however I'm going to try and place all the tool buttons up in the primary toolbar so we make maximum use of that available space. The Sugar HIG allows for up to 16 icons, so we should be fine putting all the current tools there (and still have room for one or two more new tool button features on my todo list).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: physics testing 0_88.png
Type: image/png
Size: 21358 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100625/ea91be6c/attachment-0003.png 
-------------- next part --------------


Thanks again for your effort! Hopefully I'll be able to make a new release over this weekend :)

Kind Regards,
--Gary

>> Having a quick scan through the below patch I don't see any fallback to the old toolbar setup if someone is running an older version of Sugar. I don't want to loose compatibility 99% of our current user base if at all possible (check the git reps of Moon, Calculator, TurtleArt, and I'm sure many other activities for dual toolbar support).
>> 
>> Thanks again for taking the time to submit a patch.
>> 
>> Kind Regards,
>> --Gary