[Sugar-devel] review process changes

[Bernie Innocenti]

El Thu, 03-06-2010 a las 12:19 +0200, Tomeu Vizoso escribió:
> Thanks, this is really useful. A few observations:
> 
> - how to link tickets and patches? One way is to always end the commit
> message with a link to the bug: http://bugs.sugarlabs.org/ticket/1622
> This is what git-bz does automatically. With proper email search, you
> can get all tracmail and patch reviews with a single search.

+1

> - queue control: I still feel it will be harder to find the right
> patch to review but at the same time, in all the other projects I
> submit patches to, I need to ping people in irc to get them reviewed.
> Should we move from a system with a strict queue to a ping-based
> system? If so, we may need a "patch manager" as mentioned in
> http://producingoss.com/en/producingoss.html#patch-manager

I'm not a fan of patch managers, but Patchwork seems to be a very good
one with a lightweight interface.

Ping-based systems work well in practice because it puts the initiative
on the side which submitted the patch and presumably cares the most
about it.

It works more like TCP than ping: if the maintainer forgot about your
patch, you keep resending your patch until you obtain an ACK (or a NAK).

Like in TCP, resending should be an exceptional case. If all patches
routinely need to be resent multiple times, it means that we have
insufficient reviewer bandwidth.

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/