[Sugar-devel] [record] Fixes to the UI

[Bernie Innocenti]

El Mon, 07-06-2010 a las 03:02 +0100, Martin Dengler escribió:
> On Mon, Jun 07, 2010 at 12:04:18AM +0530, anishmangal2002 at gmail.com wrote:
> [...]
> > @@ -884,6 +939,10 @@ class UI:
> >                      kids[i].setButtClickedId(BUTT_CLICKED_ID)
> >  
> >  
> > +    def actuallyHideAllWindows( self ):
> > +        for i in range (0, len(self.windowStack)):
> > +            self.windowStack[i].hide_all()
> > +
> >      def hideAllWindows( self ):
> >          for i in range (0, len(self.windowStack)):
> >              self.moveWinOffscreen( self.windowStack[i] )
> 
> Why don't you just fix hideAllWindows()?
> 
> > @@ -1913,22 +2036,22 @@ class ScrubberWindow(gtk.Window):
> >          self.add( self.hbox )
> >  
> >          self.button = gtk.Button()
> > -        buttBox = gtk.EventBox()
> > -        buttBox.add(self.button)
> > -        buttBox.modify_bg( gtk.STATE_NORMAL, Constants.colorBlack.gColor )
> > +        self.buttBox = gtk.EventBox()
> > +        self.buttBox.add(self.button)
> > +        self.buttBox.modify_bg( gtk.STATE_NORMAL, Constants.colorBlack.gColor )
> 
> great variable name that you inherited, there...might as well rename
> it to something more standard like "buttonBox" while you're at it.

Or maybe "button_box". CamelCase does not seem to be very fashionable
among Python developers.

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/