[Sugar-devel] [PATCH][record] Fixes to the UI

Daniel Drake dsd at laptop.org
Mon Jun 7 12:08:33 EDT 2010


On 6 June 2010 15:54, Anish Mangal <anishmangal2002 at gmail.com> wrote:
>> At least for myself, I'd like to see more detail here -- how was
>> it broken?
>
> Sure. The record UI consists of many windows/widgets. In a particular
> mode or view, it displays and resizes the widgets appropriate for that
> view the tries to hide the other windows by moving them off-screen.

There was probably a reason why it moved them off screen instead of hiding them.
Do you have any idea what it is?

> The patch (which I must confess is not an ideal fix), works by
> resizing (to size 1px by 1px) and hiding the widgets not required in a
> particular view/mode. To accomplish that, I created the
> 'resizewindows' method. Also, in the 'updatevideocomponents' method I
> hide the widgets not required in a particular view.

This is a great start but we should look towards that 'ideal fix' route.
If we are no longer moving windows offscreen, I would expect your
patch to remove a load of code that does that, but I don't see it.
Also, if you are hiding widgets, I don't see any reason to resize them
to 1x1.

Daniel


More information about the Sugar-devel mailing list