[Sugar-devel] [DESIGN] Problem with Pippy layout on <=0.84

[Walter Bender]

On Sat, Jul 31, 2010 at 10:34 AM, Anish Mangal
<anishmangal2002 at gmail.com> wrote:
>>> > I agree that 'hiding' the action buttons away in a toolbar is rather
>>> > unfortunate :-( , but wouldn't placing buttons as in the original
>>> > layout eat up vertical space?
>>>
>>> No more than before (as has been the design for years).
>>
>> The old design with the buttons in the middle always struck me as
>> non-standard in Sugar.
>>
>> I prefer the new design with all buttons in the toolbars. If it causes
>> problems with Sugar 0.84, maybe we could simply mark the new bundle as
>> 0.86-0.88 only?
>
> There is another way around this. alsroot, bemasc suggested using a
> local 'toolkit' version. This can be seen implemented in the
> "fully-bundled" branches of flipstiks, cartoonbuilder, speak. The idea
> is to use a local toolkit copy so that all activities are consistent
> across 0.82-0.88 and use the >=0.86 toolbar.
>
> In the case of pippy, this means that the action buttons will always
> be visible on the main activity toolbar. Here [1] is an xo with the
> same implemented. This has been tested to work on 0.82-xo1, 0.84-xo1
> (build 301), 0.88-jhbuild.
>
> Does anyone see roadblocks in using this scheme?

With this version, I n longer have an edit toolbar. This is a regression.

It really is not so difficult to maintain toolbars across different
versions. You can share most of the code even if the layout f the
buttons changes. See Abacus as an example.

-walter

>
> [1] http://people.sugarlabs.org/~anish/Pippy-37-toolbar-fix-new.xo
>
>> You are correct, and also wrong.  Alexey (alsroot) created a system called
>> "toolkit" that lets you backport the toolbars to older Sugar versions.
>>
>> """
>> < bemasc> but could m_anish use an old version of "toolkit" to get new
>>                toolbars across Sugar versions?
>> < alsroot> bemasc: yup, in repos like flipstiks, cartoonbuilder and
>>                 speak, there are "fully-bundled" brnach w/ "toolkit"
>> directory
>>                 which is new toolbars that work on 0.82
>> """
>>
>> Using that has the advantages of only requiring the maintenance of one set
>> of toolbars, and achieving consistency across Sugar versions.  It has the
>> disadvantage of breaking consistency with other Activities on <0.86.
>>
>
> Anish
>
>>
>> --
>>   // Bernie Innocenti - http://codewiz.org/
>>  \X/  Sugar Labs       - http://sugarlabs.org/
>>
>>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>



-- 
Walter Bender
Sugar Labs
http://www.sugarlabs.org