[Sugar-devel] [PATCH] Remove hard-coded School Server URL when XOs register #sl1976

[Bernie Innocenti]

On Sun, 2010-07-04 at 10:33 +1200, Tim McNamara wrote:
> Hi there,

> Ref http://bugs.sugarlabs.org/ticket/1976

> Bevaviour of the software is now independent of the hardware that
> Sugar is running. All registrations will look for Jabber server
> settings from /desktop/sugar/collaboration/jabber_server. However,
> this patch retains the REGISTER_URL as an option for systems
> administrators. This prevents currently written documentation for the
> XS / XO registration from breaking.

In order to keep the old behavior, this patch would also need to set the
default value of /desktop/sugar/collaboration/jabber_server to
"schoolserver". Also, the lines "else: url = url" in your patch seem
redundant.

Another tip: sending patches as plain text (as opposed to attachments)
makes it easier to review them inline. The combination of "git
format-patch" plus "git send-email" does the right thing.

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/