[Sugar-devel] [PATCH] touchpad section for Sugar Control Panel
sascha-ml-ui-sugar-devel at silbe.org
Wed Jul 28 09:21:55 EDT 2010
Excerpts from Walter Bender's message of Wed Jul 28 13:31:36 +0200 2010:
> > Even your latest patch still contains code that is specific to OLPC builds and will break on other systems.
> I understand that it is specific to OLPC, since it is for supporting
> hardware that is only found on the OLPC.
You're mixing terms that are related, but differ in their exact meaning. This seems to confuse you:
> But this is the first I have heard that it will break on other systems. Is my test in setup somehow
This is a feature specific to XO-1 *hardware*. You have written it in a way that makes it work only when running a specific *distribution* that has been developed by OLPC (upper-case I guess). This distribution (derived from Fedora) has no name of it's own, so people just talk about "OLPC builds" to refer to it.
If somebody - like me - runs a non-OLPC distribution on their XO-1, your patch will break. I haven't checked whether it would just render the feature unusable or break unrelated parts (e.g. the keyboard selection is known to make Sugar fail to start up at all on armel ).
> > Of course it's perfectly fine for you to say you only care about OLPC builds for XO-1 (because the number of XO-1s running non-OLPC builds is minimal, especially if you don't count developers). But in that case your patch should be included in the OLPC builds, not in Sugar mainline.
> To include this in OLPC builds and not Sugar in general is a
> reasonable argument. The only counter argument I could make would be
> that some portion of the OLPC users are relying on builds that are not
> provided directly by OLPC.
There are two options:
1. They indeed use a different distribution. In that case your patch wouldn't work for them in the first place.
2. They are running a derivative of the OLPC distribution. In that case they should be able to pick up Sugar packages with your patch from OLPC.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100728/4729728a/attachment.pgp
More information about the Sugar-devel