[Sugar-devel] [DESIGN] Re: #1842 UNSP: Journal does not provide any error message on write errors

[Anish Mangal]

On Mon, Jul 12, 2010 at 7:53 PM, Aleksey Lim <alsroot at member.fsf.org> wrote:
> On Mon, Jul 12, 2010 at 12:25:17PM +0000, Aleksey Lim wrote:
>> ----- Forwarded message from Sugar Labs Bugs <bugtracker-noreply at sugarlabs.org> -----
>>
>> From: Sugar Labs Bugs <bugtracker-noreply at sugarlabs.org>
>> Subject: Re: #1842 UNSP: Journal does not provide any error message on write
>>       errors
>> Cc: bugs at lists.sugarlabs.org
>> Reply-To: sugar-devel at lists.sugarlabs.org
>> Date: Mon, 12 Jul 2010 12:23:33 -0000
>>
>> #1842: Journal does not provide any error message on write errors
>> ------------------------------------------+---------------------------------
>>     Reporter:  bernie                     |          Owner:  alsroot
>>         Type:  defect                     |         Status:  assigned
>>     Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
>>    Component:  sugar                      |        Version:  0.84.x
>>     Severity:  Unspecified                |       Keywords:  journal, sugar-love, dev-love, r?
>> Distribution:  Unspecified                |   Status_field:  Needinfo
>> ------------------------------------------+---------------------------------
>> Changes (by alsroot):
>>
>>   * status_field:  Unconfirmed => Needinfo
>>
>>
>> Comment:
>>
>>  Patch uses NotifyRedAlert but it is not part of sugar-toolkit i.e. code
>>  won't work, what about just NotifyAlert and switch to red one later?
>
> outdated, new patch[1] uses ErrorAlert

Just to add, ErrorAlert is made available using this patch[2]

>
>>  Also, patch uses _('Alert') for alert title, could be not so informative
>>  :), what about just "Disk storage error"?
>
> outdated as well
>
>>  volumestoolbar.py emits volume-error signal with error text taken from
>>  exception, not sure if it is a good idea to pass it directly to user
>>  visible message?
>>
>>  any ideas?

For IOError, its corresponding strerror is used. For ValueError
(which, amongst another scenarios can be raised in case there is no
file associated with a journal icon), the message in journal/model.py
isn't gettexed. Further, it doesn't seem that the ValueError messages
were meant to be displayed as GUI Alerts.

So given this, should one 're'-implement a similar check in
journal/volumestoolbar.py to ascertain the existence of any file
associated with the journal icon, or modify the ValueError messages.in
journal/model.py

>
> [1] http://people.sugarlabs.org/anish/0001-Journal-show-error-message-on-write-failure-1842.patch
[2] http://people.sugarlabs.org/anish/0001-Add-ErrorAlert-inherited-from-Alert.patch
>
> --
> Aleksey
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>

--
Anish