[Sugar-devel] icon-slicer and sugar-artwork

[Sascha Silbe]

Excerpts from pbrobinson at gmail.com's message of Sun Jul 11 16:47:41 +0000 2010:

> [...] It currently needs icon-slicer but I
> think its an old dep that is still in configure.ac but no longer used,
> if I drop it out of configure.ac and rebuilt it all builds OK without
> it.
It will fail, but in a non-obvious way. Here's the relevant part of the
build log after applying your patch and removing icon-slicer from the
system:

make[3]: Entering directory `/home/sascha.silbe/sugar-jhbuild/source/sugar-artwork/cursor/sugar'
image-dir=../../cursor/sugar --output-dir=../../cursor/sugar ../../cursor/sugar/sugar.cursortheme
/bin/bash: image-dir=../../cursor/sugar: No such file or directory
make[3]: [sugar.stamp] Error 127 (ignored)

Let's take a look at the corresponding make rule:

sascha.silbe at xo-bine:~/sugar-jhbuild/source/sugar-artwork$ grep -B 1 -A 2 ICON_SLICER cursor/sugar/Makefile.am 
sugar.stamp: $(sugar_images) $(THEMEGEN) sugar.cursortheme
        $(ICON_SLICER) --image-dir=$(IMAGE_DIR) --output-dir=$(OUTPUT_DIR) $(IMAGE_DIR)/sugar.cursortheme
        touch sugar.stamp

Since ICON_SLICER is never set, $(ICON_SLICER) will expand to the empty
string. So the line make tries to execute is:

--image-dir=../../cursor/sugar --output-dir=../../cursor/sugar ../../cursor/sugar/sugar.cursortheme

A leading minus means "ignore the exit status of this command" and will
be removed prior to executing the command. Apparently the second minus is
stripped as well, so make will try to execute

image-dir=../../cursor/sugar --output-dir=../../cursor/sugar ../../cursor/sugar/sugar.cursortheme

and ignore the exit status.

See Debian #555963 for what will happen at runtime if icon-slicer doesn't work (or isn't installed).

Sascha

[1] http://bugs.debian.org/555963
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100711/9560b385/attachment.pgp