[Sugar-devel] pylint / pep8 (was: Re: review queue)

[Tomeu Vizoso]

On Wed, Jan 27, 2010 at 16:45, Sascha Silbe
<sascha-ml-ui-sugar-devel at silbe.org> wrote:
> On Wed, Jan 27, 2010 at 03:59:31PM +0100, Tomeu Vizoso wrote:
>
>> Hmm, this is a good suggestion, but I think we should make pylint
>> installation and running a bit easier, I think we have regressed there
>> in jhbuild.
>
> I don't think we can get much easier for pylint:
>
> sascha.silbe at twin:~$ ~/sugar-jhbuild/sugar-jhbuild run pylint sugar
> Warning: unknown distro version, automatic fallback to unstable.

Ah, was looking for the older "check" command.

Thanks, have updated the wiki at
http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines#Tools

If someone would like to revive the cron job that ran pylint every day
and emailed the results to sugar-devel, I think it would be great.

Thanks,

Tomeu

> sascha.silbe at twin:~$
>
>
> We could certainly improve on the current code quality so patch submitters
> have a better time finding their own mistakes:
>
> (sugar-jhbuild)sascha.silbe at twin:~$ ~/sugar-jhbuild/sugar-jhbuild run pylint
> jarabe |egrep -v '^([ *]|$)' |cut -d : -f 1 |sort |uniq -c|sort -n -r
>
> ** (pylint:16720): WARNING **: Trying to register gtype 'XklEngineFeatures'
> as flags when in fact it is of type 'GEnum'
>
> ** (pylint:16720): WARNING **: Trying to register gtype 'WnckWindowState' as
> flags when in fact it is of type 'GEnum'
>
> ** (pylint:16720): WARNING **: Trying to register gtype 'WnckWindowActions'
> as flags when in fact it is of type 'GEnum'
>
> ** (pylint:16720): WARNING **: Trying to register gtype
> 'WnckWindowMoveResizeMask' as flags when in fact it is of type 'GEnum'
>      81 E1101
>      11 W0622
>       9 W0621
>       9 C0322
>       7 W6501
>       6 W0611
>       4 W0612
>       2 E1120
>       2 C0301
>       1 W0702
>       1 W0402
>
>
>
> I'm in the process of adding pep8 to sugar-jhbuild as well.
>
> CU Sascha
>
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iQEcBAEBAgAGBQJLYF+JAAoJELpz82VMF3Da+p0IALZQxbP4CFzCc4Sxd/gAkTK4
> Flpj0XF018u8ITUW7UHTJqk13CKdkltIj9ZEu31wek+xplzzpkPUdSJGyFGPyup0
> FLWYKolvMi7JosdNo5joJeJ7l2R2+o6N+nP6JswYbk7CtD/T1Zv7bo3wd8FfRUa2
> PiEib6H8PW77gbuR2uh5zF0e3fYJQGIFfRsh5t809IkAB6DwVe8IqfuxDoigYHgT
> gvlxbqFemAe1M4Z6Ip8UynJAIFT0TRg9OS0SkJsunTkQUqq626TXbm1IK+JwAdeB
> BYE+e5lf5Ta6mraBnGwutRXxt9ZmKro+OOSQAcTCGAOI35jx7xQuyO/sih8QG/k=
> =ORYr
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>