[Sugar-devel] review queue

[Tomeu Vizoso]

On Wed, Jan 27, 2010 at 16:19, Sascha Silbe
<sascha-ml-ui-sugar-devel at silbe.org> wrote:
> On Wed, Jan 27, 2010 at 03:39:41PM +0100, Tomeu Vizoso wrote:
>
>> - revive the cron job that posted weekly reports to the mailing list
>> about what is in the queue and for how long has been there,
>
> What about submitting the patches to a mailing list (which is as simple as
> invoking "git send-email" for the submitter) for review instead of on Trac
> where significant effort is required not only to post but also to locate and
> inspect them?

I like this from the patches POV, but I would miss the tracking part
of it. The book Producing Open Source Software talks about the
importance of the bug tracker and the mailing list being integrated, I
think this is similar to Debian's system?

http://producingoss.com/

>> - put more resources into reviewing:
>
> I've done some reviews in the past (and hope they were considered useful).
> With the above change my overhead is reduced and thus I can review more
> patches in the future.
>
> Faster reaction to review requests would certainly be appreciated.

This is exactly why I started this thread.

> What I've also noticed is that the freezes seem to happen "suddenly" - at
> some point in time we realize we're going to be in freeze soon and start
> having meetings, working on patches and doing reviews again. The overall
> code quality would probably improve quite a bit if we'd manage to "spread"
> our work more evenly.
> I certainly see the point of doing freezes and concentrating on bug fixes
> after the release, but maybe next time we can start a bit earlier with
> non-bugfix work again?
> We've already improved compared to the last time, though - so there is
> progress. :)

This is why I'm proposing periodically exposing the state of the
review queue, so it's a bit more present in everybody's minds.

> And to nag about it yet again: With (more) test suites in place at least
> some of the bugs in new patches are easily discovered during development so
> we get better patches in the first place.

Agreed.

Regards,

Tomeu

> CU Sascha
>
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iQEcBAEBAgAGBQJLYFmZAAoJELpz82VMF3Da0AwH/25GaXFOl/3V+OVEH2MHQ5bO
> Fz4hhEHtTncw1aSBmvBFhmELRpSQcrBGcmPHXgsykuvanxRKKUBqq4M8+KQT0MIi
> h1CJnOj+KMCIQHJ2E0gJo+9vI2qj7DMndarFx6LnokXgTr1/c9xI3Cgdz6qAtFqb
> D4uKwsL5Lshp3fj4tegJ955g+VoH7WPMAUPPsiqt37cdyoyYpixDvIY2Uu5QdHVk
> 9YijpvsI7kWWqsf3kCauFcP0cl4tyKTtri42AH5GO0maUoqf7rrBr/dzCXfrG2Zb
> tVq9d6c//tkqDf5lhHkuLx83dRCjQEAKyPuguiZ4p3U9H4ouOwg1sFNtuyqNUv0=
> =wYMY
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>