[Sugar-devel] Write 60 possible bug saving shared work

Tomeu Vizoso tomeu at tomeuvizoso.net
Sat Feb 6 06:58:15 EST 2010


On Tue, Jan 26, 2010 at 18:41, Martin Langhoff
<martin.langhoff at gmail.com> wrote:
> On Tue, Jan 26, 2010 at 7:16 AM, Tomeu Vizoso <tomeu at sugarlabs.org> wrote:
>> Hmm, if the "keep error" dialog is shown, then I would expect a
>> backtrace in the activity logs. There is none?
>
> I was expecting it too, and there is none. There are 2 codepaths in
> sugar toolkit activity that display the dialog. I think that the issue
> is that the loglevel is wrong. Should be logger.error() in both
> codepaths.
>
> `git grep -C 4 _show_keep_failed_dialog` shows the spots...

You are right, thanks for spotting it, would be nice to backport the
fix to 0.84.

Regards,

Tomeu

> cheers,
>
>
> m
> --
>  martin.langhoff at gmail.com
>  martin at laptop.org -- School Server Architect
>  - ask interesting questions
>  - don't get distracted with shiny stuff  - working code first
>  - http://wiki.laptop.org/go/User:Martinlanghoff
>


More information about the Sugar-devel mailing list