[Sugar-devel] [PATCH] sl#2544 Adding Smiley Support to Chat Application

[Peter Robinson]

On Tue, Dec 28, 2010 at 5:24 PM, Sascha Silbe
<sascha-ml-reply-to-2010-4 at silbe.org> wrote:
> Excerpts from Mukesh Gupta's message of Sun Dec 26 20:13:57 +0100 2010:
>
> [pippy_app.py]
>> +def from_svg_at_size(filename=None, width=None, height=None, handle=None,
>> +        keep_ratio=True):
>> +    """Scale and load SVG into pixbuf"""
> [...]
>
>> +def create_pngs():
> [...]
>
> I wonder if we could instead add persistent cache support to
> sugar-toolkit (sugar.graphics.icon._IconBuffer is an in-memory cache for
> SVGs). Other activities are likely to benefit from that.
>
> [temp/1.svg]
>> +   sodipodi:docbase="/home/jimmac/src/cvs/tango-icon-theme/scalable/emotes"
>
> This looks like it got copied from tango-icon-theme which is already
> packaged for distros (at least Debian ships it; can't check Fedora
> right now). Please add a dependency instead of copying files. Copies
> have a strong tendency of getting outdated.
> If you want XO bundles to work on older builds which might not have
> shipped the tango-icon-theme package, you can still include the files
> in the bundle by copying from the system location while creating the
> bundle.

Yes Fedora has it all, in fact I think we've been carry the icon
themes due to telepathy/empathy deps all along, it did cross my my
mind as to why we were adding extra icons that would likely already be
in the distro.

Peter