[Sugar-devel] [PATCH] sl#2544 Adding Smiley Support to Chat Application

[Bernie Innocenti]

On Mon, 2010-12-27 at 00:43 +0530, Mukesh Gupta wrote:

>  temp/1.svg      |  358 ++++++++++++++++++++++++++++++
>  temp/10.svg     |   29 +++
>  temp/11.svg     |  594 +++++++++++++++++++++++++++++++++++++++++++++++++
>  temp/12.svg     |  268 ++++++++++++++++++++++
>  temp/2.svg      |  657 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  temp/3.svg      |   79 +++++++
>  temp/4.svg      |  425 +++++++++++++++++++++++++++++++++++
>  temp/5.svg      |  316 ++++++++++++++++++++++++++
>  temp/6.svg      |  303 +++++++++++++++++++++++++
>  temp/7.svg      |  282 ++++++++++++++++++++++++
>  temp/8.svg      |  252 +++++++++++++++++++++
>  temp/9.svg      |  551 ++++++++++++++++++++++++++++++++++++++++++++++
>  temp/Smiley.svg |   29 +++

1) why are the smileys placed into a directory called "temp" and not
"smileys"?

2) why not give more descriptive names to the files?

3) how about calling the last one "smiley_button.svg"?

I haven't reviewed the rest of the patch, as I'm not familiar with the
Chat codebase.

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/