[Sugar-devel] [Dextrose] [PATCH] Yum-updater notifications integration

[Aleksey Lim]

On Mon, Dec 20, 2010 at 06:35:08PM -0500, Bernie Innocenti wrote:
> On Tue, 2010-12-21 at 09:28 +1100, James Cameron wrote:
> > On Mon, Dec 20, 2010 at 05:14:25PM -0500, Bernie Innocenti wrote:
> > > On Mon, 2010-12-20 at 16:56 -0300, Martin Abente wrote:
> > > > +    def __reboot_cb(self):
> > > > +        self._system_alert(_SYSTEM_REBOOT_ID, 'system-restart',
> > > > +                _('Please, reboot your computer to take into account ' \
> > > > +                        'new updates'))
> > > 
> > > Is there still a coding standard rule that lines shoulden't exceed 80
> > > chars? If so, I would like to propose an amendment: "...unless breaking
> > > th line would make the code substantially less readable".

Checking for 80 chars width is a part of sugar pylint configuration (and
default one as well, I guess).

> > > I see a lot code in free software projects looks like shit just to
> > > conform to a coding standard that was created when vt100 terminals were
> > > luxury.
> > 
> > I still use 80 character terminals and emacs, because that's how far my
> > eyes can scan text quickly.  Any longer and there's more eye movement
> > and slower reading.  Think of why newspaper columns work well.
> 
> Ok then, proposal withdrawn.
> 
> 
> > That said, I'd prefer to see the line break in your quoted code before
> > the word "to".
> 
> Also, we should probably indent continuation lines with 4 spaces, not 8.
> That would help reduce the amount of line wrapping.

imho, we can have dozens of code policies but only with one limitation,
they needs to be checked automatically via lint command.

-- 
Aleksey