[Sugar-devel] [Dextrose] [PATCH] Yum-updater notifications integration

James Cameron quozl at laptop.org
Mon Dec 20 17:28:53 EST 2010


On Mon, Dec 20, 2010 at 05:14:25PM -0500, Bernie Innocenti wrote:
> On Mon, 2010-12-20 at 16:56 -0300, Martin Abente wrote:
> > +    def __reboot_cb(self):
> > +        self._system_alert(_SYSTEM_REBOOT_ID, 'system-restart',
> > +                _('Please, reboot your computer to take into account ' \
> > +                        'new updates'))
> 
> Is there still a coding standard rule that lines shoulden't exceed 80
> chars? If so, I would like to propose an amendment: "...unless breaking
> th line would make the code substantially less readable".
> 
> I see a lot code in free software projects looks like shit just to
> conform to a coding standard that was created when vt100 terminals were
> luxury.

I still use 80 character terminals and emacs, because that's how far my
eyes can scan text quickly.  Any longer and there's more eye movement
and slower reading.  Think of why newspaper columns work well.

That said, I'd prefer to see the line break in your quoted code before
the word "to".

-- 
James Cameron
http://quozl.linux.org.au/


More information about the Sugar-devel mailing list