[Sugar-devel] [PATCH] fix journal scan of external media, dev.laptop.org #10140

[Simon Schampijer]

On 11/30/2010 03:32 PM, Sascha Silbe wrote:
> Excerpts from James Cameron's message of Tue Nov 30 01:14:14 +0100 2010:
>
> [src/jarabe/journal/model.py]
>
>> +        if self._date_start is not None and self.st_mtime<  self._date_start:
>> +            return
>> +
>> +        if self._date_end is not None and self.st_mtime>  self._date_end:
>> +            return
>
> Both occurrences of self.st_mtime need to read stat.st_mtime instead
> (found by pylint).
>
> With those changes:
>
> Tested-By: Sascha Silbe<sascha-pgp at silbe.org>
> Reviewed-By: Sascha Silbe<sascha-pgp at silbe.org>
>
> Sascha

Yes, please do those changes noted from Sascha. Small nitpick from me: 
use os.path.join instead of str methods to concatenate paths.

self._pending_files.append(os.path.join(dir_path, entry))

For the patch title I would prefer something like "Make scanning of 
storage devices more robust OLPC #10140", is slightly more descriptive.

Regards,
    Simon

Acked-By: Simon Schampijer <simon at laptop.org>