[Sugar-devel] Calculate toolbars work in progress shots
Eben Eliason
eben at laptop.org
Fri Sep 11 15:11:09 EDT 2009
Looks great! The icons are quite nice.
My only suggestion is that (still retaining the modularity!) the misc
toolbar actually just be added as another secondary toolbar. That
leaves the basic toolbar mostly empty, but that's ok! This is an
instance, I think, where all of the basic functionality of the
calculator lives outside of the toolbar, and each toolbar adds
advanced functionality on top of that. Moreover, "misc" controls seem
to be the worst suited for a primary toolbar, which should instead
contain controls that are nearly always useful, or useful in all
contexts.
Eben
On Fri, Sep 11, 2009 at 2:59 PM, Gary C Martin<gary at garycmartin.com> wrote:
> Here's a quick set of screen grabs of a patch for Calculates toolbars, I'm
> making the code work for 0.82, 0.84 (keeping old style tab toolbars), and
> 0.86 (new style toolbars). To keep high re-use and minimum changes of code
> between the two toolbar styles, I'm using the same code for generating each
> toolbar, and the old 'Miscellaneous' tab content is being shown in the
> primary new toolbar design.
>
> Give me a shout if you have any feedback! I'll push my changes to a git
> clone of Calculate later tonight (all things going well):
>
>
>
>
> Regards,
> --Gary
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>
More information about the Sugar-devel
mailing list