[Sugar-devel] [RFA] Feature freeze break: Terminal

[Simon Schampijer]

On 09/09/2009 12:22 PM, Sayamindu Dasgupta wrote:
> On Wed, Sep 9, 2009 at 4:17 AM, Simon Schampijer<simon at schampijer.de>  wrote:
>> On 09/08/2009 06:38 PM, Gary C Martin wrote:
>>> On 7 Sep 2009, at 23:32, Simon Schampijer wrote:
>>>
>>>> On 09/07/2009 08:28 PM, Sayamindu Dasgupta wrote:
>>>>> Hello,
>>>>> The super awesome Simon has been kind enough to port the Terminal code
>>>>> to support the new toolbar functionality. Patch at
>>>>>
>>>>> http://git.sugarlabs.org/projects/terminal/repos/toolbars/commits/27a1fb2ca3e0d78f581b077d05843db02df393cb
>>>>>
>>>>> My tests with the code in sugar-jhbuild indicate no regressions.
>>>>> Thanks,
>>>>> Sayamindu
>>>>>
>>>> Do people think it is better to have the tabs at the top or at the
>>>> bottom?
>>> What ever the choice, we should have all activities conform to the same
>>> standard ;-p
>>>
>>> Now we have the new tab-less toolbar designs, my vote would be for real
>>> canvas content tabs to be at the top – but I do understand that it'll
>>> take a while for many activities to use the new toolbar design and that
>>> this may cause some transitional confusion. Perhaps we should wait and
>>> move canvas tabs in the next 0.88 release cycle so that the vast
>>> majority of Activities have had their old style toolbars-with-tabs
>>> replaced?
>>>
>>> Regards,
>>> --Gary
>> As we discussed in irc today, we should have the tabs at the top.
>>
>
> Ok - going ahead with that at the moment.
>
>> Sayamindu, if the strings (add, remove) are an issue, please just move back
>> to the old strings.
>
> I'm reverting to the old strings for now - will switch to new string
> as soon as string freeze gets over (given that the existing strings
> are not wrong, but could just do with a bit of polishing).
>
> Thanks,
> Sayamindu
>

Absolutely, sounds good to me!

Thanks,
    Simon