[Sugar-devel] [RFA] Feature freeze break: ImageViewer

Simon Schampijer simon at schampijer.de
Mon Sep 7 17:14:38 EDT 2009


On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote:
> On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasgupta<sayamindu at gmail.com>  wrote:
>> Hello,
>> The attached diff makes ImageViewer work with the newer toolbar
>> system. I have tested it in a sugar-jhbuild environment, and have
>> found no regressions.
>
> Based on Simon's inputs on IRC, I have updated the patch. New one is attached.
>
> Thanks,
> Sayamindu

Hmm, I think we said in a design meeting that all the buttons should be 
left aligned (expect the stop button). So maybe you want to put the 
fullscreen button the the left as well.

Please, mind the 80 colums and the two '_' for callbacks ;D

I tested all the buttons as working fine!

Thanks,
    Simon


More information about the Sugar-devel mailing list