[Sugar-devel] [PATCH] Implement tabs support

[Tomeu Vizoso]

On Sun, Jun 21, 2009 at 10:43, Simon Schampijer<simon at schampijer.de> wrote:
> On 06/17/2009 07:20 PM, Tomeu Vizoso wrote:
>>
>> Hi,
>>
>> attached are two patches that add tabs to Browse. One of the is for
>> hulahop and the other is for Browse.
>>
>> Thanks,
>>
>> Tomeu
>
> Hi Tomeu,
>
> first - thanks for these great patches. Some high level observations:
>
> - they worked for me out of the box :)
> - for me it i hard to determine which of the tabs is active at the moment -
> the different grey colors are not really strong differentiators to me

Yup, though we should fix this at the theme/engine level because we'll
have the same issue in all our tabs. We should also have a look at the
close icon.

> - the tabs have no fixed size - long titles will have much longer tabs
> (firefox does ellipsize - but maybe as long as we have space using it is ok
> too)

This is the default and I'm personally fine with that. Anyway,
changing it is very easy:

self.props.homogeneous = True

in the TabbedView constructor.

> - I think it will look better when the redesign of the toolbar is happening
> (at the moment we have tabs under tabs)

Agreed. We can also put the tabs below the canvas by just

self.props.tab_pos = gtk.POS_BOTTOM

in the TabbedView constructor.

> - we should probably have a Design meeting/discussion about it

Totally, who is interested in discussing this?

Would like to note that my main motivation in implementing this is not
adding the same level of support that Firefox and other browsers have
regarding tabs to Browse, but only to solve one of its most important
deficiencies as many sites (including www.sugarlabs.org) break when
you open all new windows in a dialog like we used to do before this
patch.