[Sugar-devel] [PATCH] Implement tabs support

[Simon Schampijer]

On 06/17/2009 07:20 PM, Tomeu Vizoso wrote:
> Hi,
>
> attached are two patches that add tabs to Browse. One of the is for
> hulahop and the other is for Browse.
>
> Thanks,
>
> Tomeu

Hi Tomeu,

first - thanks for these great patches. Some high level observations:

- they worked for me out of the box :)
- for me it i hard to determine which of the tabs is active at the 
moment - the different grey colors are not really strong differentiators 
to me
- the tabs have no fixed size - long titles will have much longer tabs 
(firefox does ellipsize - but maybe as long as we have space using it is 
ok too)
- I think it will look better when the redesign of the toolbar is 
happening (at the moment we have tabs under tabs)
- we should probably have a Design meeting/discussion about it

The technical review will follow later,
    Simon