[Sugar-devel] review of the new toolbars implementation

[Aleksey Lim]

On Fri, Jul 31, 2009 at 04:27:37AM +0000, Aleksey Lim wrote:
> On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote:
> > Hi,
> > +class _Palette(gtk.Window):
> > 
> > The palette class is very tricky and is a frequent source of bugs, we
> > shouldn't duplicate it. Either we add what you need to the existing
> > Palette, or we split it out in a BasePalette and Palette and then
> > inherit from BasePalette for this.
> 
> We have two use cases, I guess its worth waiting for 3rd use case
> (or huge refacor) and then refactor Palette code
> (I'm personally dislike idea of refactoring after 2nd use case)

It should fix new Palette related bugs in toolbarbox

http://people.sugarlabs.org/~alsroot/sugar-toolkit.patch
http://people.sugarlabs.org/~alsroot/post-sugar-toolkit.patch

-- 
Aleksey